Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to v1.17.6 #34025

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Conversation

yihau
Copy link
Contributor

@yihau yihau commented Nov 11, 2023

Problem

the bumping version action failed: https://github.com/solana-labs/solana/actions/runs/6829840095

Summary of Changes

have this bumping version PR first and will investigate it later

@yihau yihau requested a review from willhickey November 11, 2023 15:26
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Merging #34025 (4d7efc6) into v1.17 (7089f1e) will decrease coverage by 0.1%.
Report is 1 commits behind head on v1.17.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            v1.17   #34025     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         803      803             
  Lines      217916   217916             
=========================================
- Hits       178361   178355      -6     
- Misses      39555    39561      +6     

Copy link
Contributor

@willhickey willhickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The bumping version action fails because it doesn't have permission to create the feature branch. There's a way to grant it permission to create a branch but only with the API, not with the UI. I'll try to figure it out this week. If that doesn't work I can set it up to use my fork to create the feature branch. That would be a little brittle, but easy to switch to some other fork if need be.

@willhickey willhickey merged commit 6418bf3 into solana-labs:v1.17 Nov 12, 2023
16 checks passed
@yihau yihau deleted the version_bump_v1.17.6 branch November 12, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants