Uses hex for the hash in accounts hash cache file names #33196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33196 +/- ##
=========================================
- Coverage 82.1% 82.1% -0.1%
=========================================
Files 785 785
Lines 211205 211205
=========================================
- Hits 173444 173405 -39
- Misses 37761 37800 +39 |
mergify bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
(cherry picked from commit 21e7f98)
brooksprumo
added a commit
that referenced
this pull request
Sep 13, 2023
(cherry picked from commit 21e7f98)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The hash part of the file name for accounts hash cache paths could be more aesthetically pleasing.
Summary of Changes
Use hex for the hash in the file name for an accounts hash cache path.
Note, since #33164 has merged, any validator will rebuild their accounts hash cache already, so now's the perfect time to rename the hash files.
Further, any mnb/testnet/devnet node running a v1.16 release will (should) see the backport of #33164 and the backport of this PR in the same future release, which solidifies the above point as well.