This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
v1.16: Report new received crds signatures and their respective origins to metrics (backport of #32504) #32674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
|
@Mergifyio rebase |
❌ Unable to rebase: user
|
|
@Mergifyio rebase |
…etrics (#32504) * screwed up old branch and syncing with upstream branch * add fixed size ring buff instead of variable sized vecdeque for reporting signatures * modify difficulty to take in n 0 bits and check if signature ending ends in n 0 bits * update to only push every 18 trailing zero bits. and clean up * report origin with signature. and set trailing 0s to 8 for local testing * change back to 18 trailing zeros and rm unused imports * run cargo rmt * run ./scripts/cargo-for-all-lock-files.sh tree * allow integer arithmetic for bit comparison * rm unused lifetime * rm duplicate entry? * re implement ring buf * put ringbuf in sorted order * ringbuf in cargo.toml now in sorted order * rm ring buf, refactor, fix trailing zero bug * fix bug in trailing zeros. was comparing wrong ones * fix needless range loop bug * fix bug * change trailing zero checking to build in methods and only report first 8 bytes of signature and origin pubkey * report full origin string and first 8 bytes of signature * set SIGNATURE_SAMPLE_TRAILING_ZEROS back to 18 * forgot to run cargo tree * avoid panic and change working * rm bs58 * pass in Option<String> into datapoint_info * shorten metric names (cherry picked from commit 80f7082)
✅ Branch has been successfully rebased |
gregcusack
force-pushed
the
mergify/bp/v1.16/pr-32504
branch
from
43a344c to
94da837
Compare
Codecov Report
@@ Coverage Diff @@
## v1.16 #32674 +/- ##
=======================================
Coverage 82.0% 82.0%
=======================================
Files 762 762
Lines 207807 207807
=======================================
Hits 170413 170413
Misses 37394 37394 |
behzadnouri
approved these changes
Aug 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #32504 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com