Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

enables merkle shreds for devnet and development clusters #32533

Merged
merged 1 commit into from
Jul 20, 2023
Merged

enables merkle shreds for devnet and development clusters #32533

merged 1 commit into from
Jul 20, 2023

Conversation

behzadnouri
Copy link
Contributor

Problem

Switching from Legacy to Merkle shreds.

Summary of Changes

Enable Merkle shreds for devnet and development clusters.

@behzadnouri behzadnouri force-pushed the merkle-shreds-dev branch 3 times, most recently from 99639ce to 567d1ea Compare July 19, 2023 18:54
@codecov
Copy link

codecov bot commented Jul 19, 2023 •
edited
Loading

Codecov Report

Merging #32533 (4cfc161) into master (6d30429) will increase coverage by 0.0%.
The diff coverage is 90.9%.

@@           Coverage Diff           @@
##           master   #32533   +/-   ##
=======================================
  Coverage    82.0%    82.0%           
=======================================
  Files         780      780           
  Lines      210721   210723    +2     
=======================================
+ Hits       172852   172874   +22     
+ Misses      37869    37849   -20

@behzadnouri behzadnouri requested review from jbiseda and steviez July 19, 2023 20:24
@behzadnouri behzadnouri requested review from jbiseda and steviez July 19, 2023 21:59
steviez
steviez reviewed Jul 19, 2023
View reviewed changes
ledger/src/shred.rs Outdated Show resolved Hide resolved
steviez
steviez approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

At a minimum, I think we should backport the change to keep testnet using merkle all the time to v1.16; don't want to accidentally turn those off. Not clear to me if we should BP the change for devnet and development clusters to v1.16 as well

@behzadnouri behzadnouri added the automerge Merge this Pull Request automatically once CI passes label Jul 19, 2023
@jbiseda
Copy link
Contributor

jbiseda commented Jul 19, 2023

LGTM!

At a minimum, I think we should backport the change to keep testnet using merkle all the time to v1.16; don't want to accidentally turn those off. Not clear to me if we should BP the change for devnet and development clusters to v1.16 as well

I think BP changes for Development makes sense.

@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Jul 19, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 19, 2023

automerge label removed due to a CI failure

@behzadnouri behzadnouri merged commit 7f2f013 into solana-labs:master Jul 20, 2023
@behzadnouri behzadnouri deleted the merkle-shreds-dev branch July 20, 2023 12:47
@behzadnouri behzadnouri added the v1.16 PRs that should be backported to v1.16 label Jul 20, 2023
mergify bot pushed a commit that referenced this pull request Jul 20, 2023
@behzadnouri @mergify
enables merkle shreds for devnet and development clusters (#32533)
1cced0d 
(cherry picked from commit 7f2f013)
@mergify mergify bot mentioned this pull request Jul 20, 2023
Merged
mergify bot added a commit that referenced this pull request Jul 20, 2023
@mergify @behzadnouri
v1.16: enables merkle shreds for devnet and development clusters (bac…
098655f 
…kport of #32533) (#32552)

enables merkle shreds for devnet and development clusters (#32533)

(cherry picked from commit 7f2f013)

Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steviez steviez steviez approved these changes

@jbiseda jbiseda Awaiting requested review from jbiseda

Assignees
No one assigned
Labels
v1.16 PRs that should be backported to v1.16
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@behzadnouri @jbiseda @steviez