This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
[TieredStorage] HotStorageFileReader #32512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhchiang-sol
force-pushed
the
ts-hot2
branch
5 times, most recently
from
a20a07b to
63a3389
Compare
Codecov Report
@@ Coverage Diff @@
## master #32512 +/- ##
=========================================
- Coverage 82.0% 82.0% -0.1%
=========================================
Files 779 779
Lines 210609 210708 +99
=========================================
+ Hits 172742 172793 +51
- Misses 37867 37915 +48 |
|
Let me try to split PRs in a different way so that we can have unit tests in each PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR introduces the reader to the hot storage accounts file.
Test Plan
Tested with the prototype implementation of the tiered account storage (#30626).
More tests will be added in the hot storage writer PRs.