This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
ci: improve CODECOV_ENVS setting #32492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryoqun
reviewed
Jul 14, 2023
Comment on lines
+111
to
+131
| # https://docs.codecov.com/docs/testing-with-docker | ||
| # We normalize CI to `1`; but codecov expects it to be `true` to detect Buildkite... | ||
| # Unfortunately, codecov.io fails sometimes: | ||
| # curl: (7) Failed to connect to codecov.io port 443: Connection timed out | ||
| CODECOV_ENVS=$(CI=true bash <(while ! curl -sS --retry 5 --retry-delay 2 --retry-connrefused https://codecov.io/env; do sleep 10; done)) | ||
| retry=5 | ||
| while :; do | ||
| if ((retry > 0)); then | ||
| echo "fetching coverage_env_script..." | ||
| else | ||
| echo "can't fetch coverage_env_script successfully" | ||
| exit 1 | ||
| fi | ||
|
|
||
| http_code=$(curl -s -o coverage_env_script -w "%{http_code}" https://codecov.io/env) | ||
| if [[ "$http_code" = "200" ]]; then | ||
| break | ||
| fi | ||
|
|
||
| echo "got http_code $http_code" | ||
| retry="$((retry - 1))" | ||
| sleep 5 | ||
| done | ||
| CODECOV_ENVS=$(CI=true bash < coverage_env_script) |
There was a problem hiding this comment.
well, i think we just need to add --fail like this, relying on curl... #32494
There was a problem hiding this comment.
maybe, my comment wasn't clear enough for suggesting --fail at #32490 (comment) ... sorry about that.
or, is there any reason we have to use manual looping? i think curl-based approach is simpler...
There was a problem hiding this comment.
I misunderstand the --fail. I thought it will direct the error message into the variable as well. thank you for pointing this out!
|
use #32494 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
another solution for #32490.
Summary of Changes
handle curl's http code
it looks like