This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Add base rust version to the output of cargo-build-sbf --version #32254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvines
reviewed
Jun 23, 2023
mvines
reviewed
Jun 23, 2023
Codecov Report
@@ Coverage Diff @@
## master #32254 +/- ##
=======================================
Coverage 82.0% 82.0%
=======================================
Files 771 771
Lines 209337 209337
=======================================
+ Hits 171740 171751 +11
+ Misses 37597 37586 -11 |
|
Looks like it's ready to be merged. |
mvines
approved these changes
Jun 23, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jun 23, 2023
) (cherry picked from commit f71cf07)
mvines
pushed a commit
that referenced
this pull request
Jun 24, 2023
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
Aug 15, 2023
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
Aug 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Platform tools version is not very informative. Additional information about the version of Rust the tools are based on could be helpful.
Summary of Changes
Add a function that extracts the version of the rust compiler installed in the platform-tools and output the version for the
--versioncommand line option of cargo-build-sbf.