This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
[TieredStorage] AccountMetaOptionalFields::size_from_flags() #32242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #32242 +/- ##
=======================================
Coverage 82.0% 82.0%
=======================================
Files 769 769
Lines 208992 209004 +12
=======================================
+ Hits 171395 171432 +37
+ Misses 37597 37572 -25 |
brooksprumo
approved these changes
Jun 22, 2023
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
Aug 15, 2023
…labs#32242) #### Summary of Changes This PR adds AccountMetaOptionalFields::size_from_flags that takes `&AccountMegaFlags` and returns the size of the AccountMetaOptionalFields based on the input AccountMegaFlags. This function is needed because the reader of the TieredAccountMeta directly extract all the Some fields of AccountMetaOptionalFields from its account block without constructing the AccountMetaOptionalFields instance. #### Test plan Improve existing unit tests that further verify the correctness of the function.
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
Aug 15, 2023
…labs#32242) #### Summary of Changes This PR adds AccountMetaOptionalFields::size_from_flags that takes `&AccountMegaFlags` and returns the size of the AccountMetaOptionalFields based on the input AccountMegaFlags. This function is needed because the reader of the TieredAccountMeta directly extract all the Some fields of AccountMetaOptionalFields from its account block without constructing the AccountMetaOptionalFields instance. #### Test plan Improve existing unit tests that further verify the correctness of the function.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR adds AccountMetaOptionalFields::size_from_flags that takes
&AccountMetaFlagsand returns the size of the AccountMetaOptionalFieldsbased on the input AccountMetaFlags.
This function is needed because the reader of the TieredAccountMeta
directly extract all the Some fields of AccountMetaOptionalFields
from its account block without constructing the AccountMetaOptionalFields
instance.
Test plan
Improve existing unit tests that further verify the correctness of the function.