Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Add metrics for invalid vote timestamps #32206

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Add metrics for invalid vote timestamps #32206

merged 1 commit into from
Jun 20, 2023

Conversation

AshwinSekar
Copy link
Contributor

Problem

No visibility when timestamps are missing

Summary of Changes

Add metrics:

  • When clock error results in not sending a timestamp
  • When refreshing a vote with no original timestamp

Normal refresh vote with timestamp can be derived from the existing metric "refresh_vote" and subtracting "refresh-timestamp-missing"

Fixes #

@AshwinSekar AshwinSekar mentioned this pull request Jun 20, 2023
Merged
CriesofCarrots
CriesofCarrots approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AshwinSekar AshwinSekar added automerge Merge this Pull Request automatically once CI passes v1.14 v1.16 PRs that should be backported to v1.16 labels Jun 20, 2023
@mergify mergify bot merged commit 4ba78de into solana-labs:master Jun 20, 2023
mergify bot pushed a commit that referenced this pull request Jun 20, 2023
@AshwinSekar @mergify
Add metrics for invalid vote timestamps (#32206)
53919a1 
(cherry picked from commit 4ba78de)
mergify bot pushed a commit that referenced this pull request Jun 20, 2023
@AshwinSekar @mergify
Add metrics for invalid vote timestamps (#32206)
71b2bd5 
(cherry picked from commit 4ba78de)
This was referenced Jun 20, 2023
Merged
Merged
mergify bot added a commit that referenced this pull request Jun 20, 2023
@mergify @AshwinSekar
v1.16: Add metrics for invalid vote timestamps (backport of #32206) (#…
9d1ca7c 
…32208)

Add metrics for invalid vote timestamps (#32206)

(cherry picked from commit 4ba78de)

Co-authored-by: Ashwin Sekar <ashwin@solana.com>
mergify bot added a commit that referenced this pull request Jun 20, 2023
@mergify @AshwinSekar
v1.14: Add metrics for invalid vote timestamps (backport of #32206) (#…
e3dda4b 
…32207)

Add metrics for invalid vote timestamps (#32206)

(cherry picked from commit 4ba78de)

Co-authored-by: Ashwin Sekar <ashwin@solana.com>
@AshwinSekar AshwinSekar deleted the timestamp-metrics branch June 21, 2023 16:43
wen-coding pushed a commit to wen-coding/solana that referenced this pull request Aug 15, 2023
@AshwinSekar @wen-coding
Add metrics for invalid vote timestamps (solana-labs#32206)
1718f1f
wen-coding pushed a commit to wen-coding/solana that referenced this pull request Aug 15, 2023
@AshwinSekar @wen-coding
Add metrics for invalid vote timestamps (solana-labs#32206)
6ff9784
wen-coding pushed a commit to wen-coding/solana that referenced this pull request Aug 15, 2023
@AshwinSekar @wen-coding
Add metrics for invalid vote timestamps (solana-labs#32206)
f9e64fd
bw-solana pushed a commit to bw-solana/solana that referenced this pull request Jan 10, 2025
@mergify @AshwinSekar @bw-solana
v1.14: Add metrics for invalid vote timestamps (backport of solana-la…
ea904c7 
…bs#32206) (solana-labs#32207)

Add metrics for invalid vote timestamps (solana-labs#32206)

(cherry picked from commit 4ba78de)

Co-authored-by: Ashwin Sekar <ashwin@solana.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CriesofCarrots CriesofCarrots CriesofCarrots approved these changes

Assignees
No one assigned
Labels
automerge Merge this Pull Request automatically once CI passes v1.16 PRs that should be backported to v1.16
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AshwinSekar @CriesofCarrots