This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
[zk-token-sdk] Make inner scalar and ristretto point of PedersenOpening and PedersenCommitment private
#32187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #32187 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 768 768
Lines 209037 209045 +8
=========================================
+ Hits 171332 171333 +1
- Misses 37705 37712 +7 |
samkim-crypto
added
v1.16
samkim-crypto
added a commit
that referenced
this pull request
Jun 21, 2023
…senOpening` and `PedersenCommitment` private (backport of #32187) (#32212) [zk-token-sdk] Make inner scalar and ristretto point of `PedersenOpening` and `PedersenCommitment` private (#32187) * make `PedersenOpening` inner scalar private * make `PedersenCommitment` inner point private (cherry picked from commit 1616123) Co-authored-by: samkim-crypto <skim13@cs.stanford.edu>
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
Aug 15, 2023
…ing` and `PedersenCommitment` private (solana-labs#32187) * make `PedersenOpening` inner scalar private * make `PedersenCommitment` inner point private
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
Aug 15, 2023
…ing` and `PedersenCommitment` private (solana-labs#32187) * make `PedersenOpening` inner scalar private * make `PedersenCommitment` inner point private
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the
ScalarandRistrettoPointcomponents of thePedersenOpeningandPedersenCommitmenttypes have visibilitypub(crate)while each of these types have getters to access the inner types.Summary of Changes
ScalarandRistrettoPointcomponents in these structs be fully privateFixes #