This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Feature - Recompile loaded programs before epoch boundary #32172
Closed
Lichtso
wants to merge
3
commits into
solana-labs:master
from
Lichtso:feature_transition_recompilation
Closed
Feature - Recompile loaded programs before epoch boundary #32172
Lichtso
wants to merge
3
commits into
solana-labs:master
from
Lichtso:feature_transition_recompilation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
feature_transition_recompilation
branch
4 times, most recently
from
June 16, 2023 18:05
79c77fe
to
a2adeb5
Compare
Codecov Report
@@ Coverage Diff @@
## master #32172 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 798 798
Lines 217101 216652 -449
=========================================
- Hits 178015 177530 -485
- Misses 39086 39122 +36 |
pgarg66
reviewed
Jun 21, 2023
Lichtso
force-pushed
the
feature_transition_recompilation
branch
from
June 22, 2023 14:21
a2adeb5
to
b8f8b29
Compare
pgarg66
previously approved these changes
Jun 22, 2023
github-actions
bot
added
the
stale
[bot only] Added to stale content; results in auto-close after a week.
label
Jul 7, 2023
pgarg66
removed
the
stale
[bot only] Added to stale content; results in auto-close after a week.
label
Jul 11, 2023
Lichtso
force-pushed
the
feature_transition_recompilation
branch
from
July 13, 2023 14:26
b8f8b29
to
483558c
Compare
pgarg66
previously approved these changes
Jul 17, 2023
Lichtso
force-pushed
the
feature_transition_recompilation
branch
2 times, most recently
from
July 25, 2023 18:17
02583fb
to
95b8971
Compare
github-actions
bot
added
the
stale
[bot only] Added to stale content; results in auto-close after a week.
label
Aug 9, 2023
Lichtso
force-pushed
the
feature_transition_recompilation
branch
from
August 17, 2023 11:23
95b8971
to
65b5132
Compare
Lichtso
removed
the
stale
[bot only] Added to stale content; results in auto-close after a week.
label
Aug 17, 2023
Lichtso
force-pushed
the
feature_transition_recompilation
branch
3 times, most recently
from
August 17, 2023 15:24
63474b9
to
b4b04cb
Compare
Lichtso
force-pushed
the
feature_transition_recompilation
branch
from
August 28, 2023 10:06
b4b04cb
to
8d957ae
Compare
Lichtso
force-pushed
the
feature_transition_recompilation
branch
3 times, most recently
from
September 6, 2023 19:33
f924d4e
to
176bfa0
Compare
github-actions
bot
added
the
stale
[bot only] Added to stale content; results in auto-close after a week.
label
Sep 21, 2023
Lichtso
force-pushed
the
feature_transition_recompilation
branch
from
September 25, 2023 13:34
176bfa0
to
6c701a4
Compare
Lichtso
removed
the
stale
[bot only] Added to stale content; results in auto-close after a week.
label
Sep 25, 2023
Lichtso
force-pushed
the
feature_transition_recompilation
branch
from
September 26, 2023 18:48
6c701a4
to
15db974
Compare
pgarg66
approved these changes
Sep 26, 2023
Closing this as it does not work. There can be multiple independent forks crossing the epoch boundary, so we can only prune once the next rooting after the epoch boundary hits. In between the epoch boundary and the first root we potentially need to replay both feature sets depending on the slot, thus each Bank needs to know its program runtime environment. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Continuation of #31945, to not only prune old programs which were verified and compiled against the feature set of the previous epoch, but also start recompiling them for the upcoming one before it hits.
Summary of Changes
ProgramRuntimeEnvironment
.LoadedPrograms::upcoming_program_runtime_environment_v1
.Bank::load_program()
.FEATURES_AFFECTING_RBPF
.