This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Remove --locked for cli-arg based patch... #31971
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I'm a bad guy who is testing in the production environment (of ci). T_T
so, it turned out that
cargo --config ...
based patching doesn't work in combination with--locked
. thinking about the purpose of--locked
, it does make sense.That means the patched
ntapi
won't be used and windows build fails still...........https://github.com/solana-labs/solana/actions/runs/5177053842/jobs/9326670925#step:6:2691 :
as an excuse, i rightfully tested at my fork's github actions to verify cli-arg based patching is working.... but i originally forgot to pass
--locked
at that time... this time, i confirmed giving--locked
produce the above warn as well in my fork build, implying the existence of--locked
was significant...Summary of Changes
Remove --locked for now. obviously, this kind of change isn't backportable to v1.16. so, solana-labs/solana-program-library#4471 is now blocker for windows binary for v1.16.x.
Fixes #