-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Fullnode rpc to exit with unsafe config #3082
Fullnode rpc to exit with unsafe config #3082
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3082 +/- ##
========================================
- Coverage 78.5% 78.1% -0.4%
========================================
Files 136 137 +1
Lines 19944 20134 +190
========================================
+ Hits 15660 15744 +84
- Misses 4284 4390 +106 |
Can you find a better term than "unsafe"? Rust uses that term for the user to communicate to the compiler "your memory-safety rules are too conservative, back off, I got this". |
@garious, debug seems to benign. A super safe way to do this would be to have 1 config item per “unsafe” test. So I could call this DebugRpcFullnodeExit |
sure or "TestOnly" |
I'd rather the flag be very specific, But this change overall is great, once it lands I'll expose it as a flag to the fullnode program since I'd like to use it in the bash integration tests and network deployment scripts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the naming nit
* extract solana-nonce crate * activate solana-nonce/serde in solana-program * update lock file * post-rebase fixes * add docsrs metadata Co-authored-by: Jon C <me@jonc.dev> * add doc_auto_cfg * reorganise modules --------- Co-authored-by: Jon C <me@jonc.dev>
Problem
Leader failure fault tolerance for an in-process LocalCluster requires the node to expose an exit mechanism via an RPC. This mechanism is only available with the JsonRpcConfig::Unsafe fullnode option.
Summary of Changes
exit
signal from the fullnode through to TPU and TVUFixes #