This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Fix client get_program_accounts_with_config calls with context #28772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jstarry , I picked you because you had assigned the original issue to yourself, but let me know if you want to pass on review. Thx! |
jstarry
reviewed
Nov 9, 2022
CriesofCarrots
force-pushed
the
fix-client-gpa-config
branch
from
99394e0 to
9b94879
Compare
Done in eb7c89f |
jstarry
approved these changes
Nov 16, 2022
mergify bot
pushed a commit
that referenced
this pull request
Nov 16, 2022
* Move OptionalContext to solana-rpc-client-api * Add helper function * Add failing test * Support OptionalContext in RpcClient::get_program_accounts_with_config (cherry picked from commit b18ef88) # Conflicts: # client/src/nonblocking/rpc_client.rs # client/src/rpc_client.rs # rpc/src/rpc.rs
mergify bot
pushed a commit
that referenced
this pull request
Nov 16, 2022
* Move OptionalContext to solana-rpc-client-api * Add helper function * Add failing test * Support OptionalContext in RpcClient::get_program_accounts_with_config (cherry picked from commit b18ef88) # Conflicts: # rpc/src/rpc.rs
mergify bot
added a commit
that referenced
this pull request
Nov 16, 2022
…ort #28772) (#28846) * Fix client get_program_accounts_with_config calls with context (#28772) * Move OptionalContext to solana-rpc-client-api * Add helper function * Add failing test * Support OptionalContext in RpcClient::get_program_accounts_with_config (cherry picked from commit b18ef88) # Conflicts: # client/src/nonblocking/rpc_client.rs # client/src/rpc_client.rs # rpc/src/rpc.rs * Fix conflicts Co-authored-by: Tyera Eulberg <tyera@solana.com>
mergify bot
added a commit
that referenced
this pull request
Nov 17, 2022
…ort #28772) (#28847) * Fix client get_program_accounts_with_config calls with context (#28772) * Move OptionalContext to solana-rpc-client-api * Add helper function * Add failing test * Support OptionalContext in RpcClient::get_program_accounts_with_config (cherry picked from commit b18ef88) # Conflicts: # rpc/src/rpc.rs * Fix conflicts Co-authored-by: Tyera Eulberg <tyera@solana.com>
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Dec 16, 2022
…a-labs#28772) * Move OptionalContext to solana-rpc-client-api * Add helper function * Add failing test * Support OptionalContext in RpcClient::get_program_accounts_with_config
nickfrosty
pushed a commit
to nickfrosty/solana
that referenced
this pull request
Jan 4, 2023
…a-labs#28772) * Move OptionalContext to solana-rpc-client-api * Add helper function * Add failing test * Support OptionalContext in RpcClient::get_program_accounts_with_config
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As per #25869,
RpcClient::get_program_accounts_with_config()cannot deserialize the responses from all current clusters whenwith_contextis set to true. #17399 added theOptionalContextwrapper to the response from thegetProgramAccountsRPC endpoint, but didn't add any handling to client methods. This has been broken in practice since whenever that change was released to public clusters, which unfortunately means all current branches.Summary of Changes
Add support for OptionalContext to
nonblocking::RpcClient::get_program_accounts_with_config()Fixes #25869