This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
limit repairs to top staked requests in batch #28673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbiseda
force-pushed
the
repair-sort-req-by-stake
branch
from
0357ea2 to
558c426
Compare
jbiseda
force-pushed
the
repair-sort-req-by-stake
branch
from
558c426 to
9ff5fbf
Compare
behzadnouri
previously approved these changes
Nov 16, 2022
core/src/serve_repair.rs
Outdated
Comment on lines
475
to
476
| for batch in reqs_v { | ||
| for packet in &batch { |
There was a problem hiding this comment.
maybe instead of nested for loops and double indentation something like:
for packet in reqs_v.iter().flatten() {
core/src/serve_repair.rs
Outdated
|
|
||
| if decoded_reqs.len() > MAX_REQUESTS_PER_ITERATION { | ||
| stats.dropped_requests_low_stake += decoded_reqs.len() - MAX_REQUESTS_PER_ITERATION; | ||
| decoded_reqs.sort_by(|(_, _, s1), (_, _, s2)| s2.cmp(s1)); |
There was a problem hiding this comment.
decode_reqs.sort_by_key(|(_, _, stake)| Reverse(*stake))
core/src/serve_repair.rs
Outdated
| .map(|nodes| nodes.get(request.sender())) | ||
| .unwrap_or_default() | ||
| { | ||
| Some(stake) => { |
There was a problem hiding this comment.
I don't know if epoch_staked_nodes includes any zeros, probably not.
Nevertheless I guess it wouldn't hurt to be explicit here and don't rely on that presumption.
Something like:
let stake = epoch_staked_nodes
.as_ref()
.and_then(|stakes| staked.get(request.sender()))
.unwrap_or_default();
if stake == 0 {
// ...
} else {
//...
}
mergify
bot
dismissed
behzadnouri’s stale review
Pull request has been modified.
|
please do not backport this until testnet is restarted and is stable. |
mergify bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
(cherry picked from commit 17ee334)
jbiseda
added a commit
to jbiseda/solana
that referenced
this pull request
Dec 9, 2022
… to non-MainnetBeta clusters
jbiseda
added a commit
that referenced
this pull request
Dec 11, 2022
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Dec 16, 2022
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Dec 16, 2022
nickfrosty
pushed a commit
to nickfrosty/solana
that referenced
this pull request
Jan 4, 2023
nickfrosty
pushed a commit
to nickfrosty/solana
that referenced
this pull request
Jan 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
repair requests from staked nodes should be prioritized.
Summary of Changes
For each iteration we will select
MAX_REQUESTS_PER_ITERATIONrequests to process. Accept up to2 * MAX_REQUESTS_PER_ITERATIONpackets before load shedding packets in the incoming channel. Select topMAX_REQUESTS_PER_ITERATIONrequests by stake of requesting node.Limiting this change to testnet.
Fixes #