This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
[zk-token-sdk] divide fee encryption into two ciphertexts #28472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fyi #28979 ... I went ahead and rebased |
mergify bot
pushed a commit
that referenced
this pull request
Dec 2, 2022
* divide fee encryption into two ciphertexts * clippy * update range proof * add fee ciphertext decryption * clean up split_u64 function * remove unnecessary casting (cherry picked from commit 11efaf7) # Conflicts: # zk-token-sdk/src/instruction/transfer_with_fee.rs
mergify bot
added a commit
that referenced
this pull request
Dec 2, 2022
…28472) (#29036) * [zk-token-sdk] divide fee encryption into two ciphertexts (#28472) * divide fee encryption into two ciphertexts * clippy * update range proof * add fee ciphertext decryption * clean up split_u64 function * remove unnecessary casting (cherry picked from commit 11efaf7) # Conflicts: # zk-token-sdk/src/instruction/transfer_with_fee.rs * resolve conflict marker Co-authored-by: samkim-crypto <skim13@cs.stanford.edu>
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Dec 16, 2022
…s#28472) * divide fee encryption into two ciphertexts * clippy * update range proof * add fee ciphertext decryption * clean up split_u64 function * remove unnecessary casting
nickfrosty
pushed a commit
to nickfrosty/solana
that referenced
this pull request
Jan 4, 2023
…s#28472) * divide fee encryption into two ciphertexts * clippy * update range proof * add fee ciphertext decryption * clean up split_u64 function * remove unnecessary casting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The transfer fees for confidential transfers are encrypted as one single ciphertext, which prevents it from being added on to the destination token account's pending balance.
Summary of Changes
Divide the transfer fee and encrypt it as two separate ciphertexts. Update the zk proofs accordingly.