This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
check is_forwarded packet earlier #28159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tao-stones
force-pushed
the
filter_forwarded_earlier
branch
2 times, most recently
from
e7e8169 to
73d3bcc
Compare
tao-stones
force-pushed
the
filter_forwarded_earlier
branch
5 times, most recently
from
8da53ba to
1f6803d
Compare
AshwinSekar
previously approved these changes
Nov 1, 2022
| .count() | ||
| ); | ||
| // Only prcoess packets not yet forwarded | ||
| let (packets_to_forward, tracer_packet_indexes) = self |
There was a problem hiding this comment.
nit: could rename to is_tracer_packet or something more descriptive since these are not really indexes
mergify
bot
dismissed
AshwinSekar’s stale review
Pull request has been modified.
tao-stones
force-pushed
the
filter_forwarded_earlier
branch
from
3c6b85c to
e8acf5e
Compare
tao-stones
added
the
automerge
xiangzhu70
pushed a commit
to xiangzhu70/solana
that referenced
this pull request
Nov 16, 2022
* check and filter is_forwarded packet earlier * review fix: renaming; and rebase
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Dec 16, 2022
* check and filter is_forwarded packet earlier * review fix: renaming; and rebase
nickfrosty
pushed a commit
to nickfrosty/solana
that referenced
this pull request
Jan 4, 2023
* check and filter is_forwarded packet earlier * review fix: renaming; and rebase
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
refactor (per #28146 ) to check and filter is_forwarded packets earlier.
Summary of Changes
Fixes #28146