This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
fix: replace js-sha3 with @noble/hashes/sha3
#27630
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR aims to replace the keccak_256 hashing algorithm with a smaller one.
Summary of Changes
js-sha3
with@noble/hashes/sha3
Bundle Size
Used
package-build-stats
to analyze the size change locally.tl;dr a ~3% reduction in bundle size after gzip.
Dependency tree
Replaced
js-sha3
for@noble/hashes/sha3
.Produced using https://npmgraph.js.org/
Performance
Consider this keypair generation code:
Take 10 trials:
Results
~180% slower than the existing library.
Compatibility notes
Both of these libraries have no dependencies, thought
@noble/hashes
introduces a dependency onBigInt
. We wrote more about this here: https://twitter.com/steveluscher/status/1565232091260157952Fixes #27629