Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

serialize incremental_snapshot_hash (backport #26839) #27212

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 17, 2022

This is an automatic backport of pull request #26839 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* serialize incremental_snapshot_hash

* pr feedback

(cherry picked from commit 225cddc)
@mergify mergify bot added the automerge Merge this Pull Request automatically once CI passes label Aug 17, 2022
@mergify
Copy link
Contributor Author

mergify bot commented Aug 17, 2022

automerge label removed due to a CI failure

@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Aug 17, 2022
@brooksprumo
Copy link
Contributor

brooksprumo commented Aug 18, 2022

Run this backport by #releng to make sure they're ok with it. Here's the original context:
https://discord.com/channels/428295358100013066/439194979856809985/1004972412158361671
(see Jack's comment just below, since apparently that link doesn't highlight where I expect it to.)

@mergify mergify bot added the automerge Merge this Pull Request automatically once CI passes label Aug 23, 2022
@jeffwashington
Copy link
Contributor

Without this, snapshots generated by master will fail to load in 1.11.

[2022-08-23T14:52:36.958774634Z WARN  solana_runtime::snapshot_utils] Snapshot Error: "invalid snapshot data file: /mnt/nvme1n1/ledger/snapshot/tmp-snapshot-archive-dA3ozQ/snapshots/147262324/147262324 has 481637072 bytes, however consumed 481637071 bytes to deserialize"

@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Aug 23, 2022
@mergify
Copy link
Contributor Author

mergify bot commented Aug 23, 2022

automerge label removed due to a CI failure

@mergify mergify bot added the automerge Merge this Pull Request automatically once CI passes label Aug 23, 2022
@mergify mergify bot merged commit c6ea14c into v1.11 Aug 23, 2022
@mergify mergify bot deleted the mergify/bp/v1.11/pr-26839 branch August 23, 2022 16:32
jeffwashington added a commit that referenced this pull request Aug 23, 2022
jeffwashington added a commit to jeffwashington/solana that referenced this pull request Sep 13, 2022
…ana-labs#27212)

serialize incremental_snapshot_hash (solana-labs#26839)

* serialize incremental_snapshot_hash

* pr feedback

(cherry picked from commit 225cddc)

Co-authored-by: Jeff Washington (jwash) <wash678@gmail.com>
jeffwashington added a commit to jeffwashington/solana that referenced this pull request Sep 13, 2022
    only READ BankIncrementalSnapshotPersistence in 1.11 (solana-labs#27345)
    serialize incremental_snapshot_hash (backport solana-labs#26839) (solana-labs#27212)
jeffwashington added a commit to jeffwashington/solana that referenced this pull request Sep 13, 2022
…ana-labs#27212)

serialize incremental_snapshot_hash (solana-labs#26839)

* serialize incremental_snapshot_hash

* pr feedback

(cherry picked from commit 225cddc)

Co-authored-by: Jeff Washington (jwash) <wash678@gmail.com>
jeffwashington added a commit to jeffwashington/solana that referenced this pull request Sep 13, 2022
    only READ BankIncrementalSnapshotPersistence in 1.11 (solana-labs#27345)
    serialize incremental_snapshot_hash (backport solana-labs#26839) (solana-labs#27212)
jeffwashington added a commit to jeffwashington/solana that referenced this pull request Sep 14, 2022
…ana-labs#27212)

serialize incremental_snapshot_hash (solana-labs#26839)

* serialize incremental_snapshot_hash

* pr feedback

(cherry picked from commit 225cddc)

Co-authored-by: Jeff Washington (jwash) <wash678@gmail.com>
jeffwashington added a commit to jeffwashington/solana that referenced this pull request Sep 14, 2022
    only READ BankIncrementalSnapshotPersistence in 1.11 (solana-labs#27345)
    serialize incremental_snapshot_hash (backport solana-labs#26839) (solana-labs#27212)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants