Refactor bank and track root and live bank checkpoints. #2640

aeyakovenko · 2019-02-01T22:31:58Z

Problem

Need a way to track root and live bank state in the system and handle rollback.

Summary of Changes

bank split into BankCheckpoint and BankState that composes the checkpoints
live and root BankState is reachable from the bank
made the RpcSubscriptions explicit. Trait objects are really not great in rust. They require a dynamic allocation, the compiler implements them as dynamic dispatch, and they cannot really compose the traits up through the Box, so you end up passing a bunch of trait level descriptions through every api that uses them.
Checkpoints module that implements a dag to keep track of the checkpoints
Forks that merges and purges the live chain as it moves along

What is not done:

refactoring the system to not use a global bank. I think in a lot places, the expected BankState instance should be passed in as a function parameter. Instead of using a bank instance to reach for the live or root fork. The problem that there are some things that should be computed from the root, and others from the live fork. last_id for a client should probably come from root, but for a vote needs to come from the live branch that is being voted on.

Fixes #2555

src/bank_checkpoint.rs

garious · 2019-02-04T23:55:02Z

src/bank_checkpoint.rs

+    }
+}
+
+impl Default for BankCheckpoint {


Looks like this can be derived automatically

src/bank.rs

aeyakovenko · 2019-02-05T00:28:29Z

#2646 design doc

garious · 2019-02-05T20:29:08Z

@rob-solana, Anatoly posted a bunch of name-change comments at the end of #2646 that also apply to this PR. Can you make those updates before this goes in?

…ite transactions or ticks

garious · 2019-02-07T21:58:42Z

src/bank.rs

-            self.process_block(&block)?;
+            let slot = block[0].tick_height / DEFAULT_TICKS_PER_SLOT;
+            if slot > 0 && block[0].tick_height % DEFAULT_TICKS_PER_SLOT == 0 {
+                //TODO: EntryTree should provide base slot


EntryTree isn't a thing anymore. And is the base slot needed? Is that just slot zero now?

garious · 2019-02-07T22:01:41Z

What's the point of Bank after this PR? Why not delete the existing Bank and call the new thing Bank?

garious · 2019-02-08T23:27:33Z

Moved to #2689

…s#2640) Enable wen_restart from command line and update comments.

aeyakovenko requested review from garious, rob-solana and mvines February 1, 2019 22:32

aeyakovenko force-pushed the checkpoints_4 branch from e6adfc7 to 3aaa0a6 Compare February 1, 2019 23:19

This was referenced Feb 2, 2019

Add design for the forking bank #2646

Merged

Bank needs to checkpoint any state it votes on #2555

Closed

aeyakovenko changed the title ~~reforkering~~ Refactor bank and track root and live bank checkpoints. Feb 4, 2019

garious reviewed Feb 4, 2019

View reviewed changes

src/bank_checkpoint.rs Outdated Show resolved Hide resolved

garious reviewed Feb 4, 2019

View reviewed changes

src/bank_checkpoint.rs Outdated Show resolved Hide resolved

garious reviewed Feb 4, 2019

View reviewed changes

src/bank_checkpoint.rs Outdated

}

}

impl Default for BankCheckpoint {

Copy link

Contributor

garious Feb 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this can be derived automatically

garious reviewed Feb 4, 2019

View reviewed changes

src/bank.rs Outdated Show resolved Hide resolved

rob-solana force-pushed the checkpoints_4 branch from aa585df to 25a726b Compare February 5, 2019 21:02

garious assigned rob-solana Feb 5, 2019

aeyakovenko and others added 15 commits February 6, 2019 10:48

reforkering

009674d

fmt

ac091ed

rebase forkup

dc5200f

fixing build all

38c6adc

leave the last block open

f3d9ff5

more tests

77c7c08

rebase fix

65166d7

replay test fix

a563740

rollback depth parameter

d20b295

cleanup

274c0e0

better replay stage

c9d77f1

s/finalized/frozen for bank_checkpoints that are no longer able to wr…

4920ca0

…ite transactions or ticks

remove println

5f09bea

disconnect blob sender so that TVU isn't replyaing onto TPU's fork

df0b621

finalize()->freeze(), code review comments

a1b0e1d

rob-solana added 8 commits February 6, 2019 10:48

rebased

e7694a6

fix window_send_test

3dee96b

remove entries_to_blocks()

182c4eb

guard against too many ticks in a slot

41a109b

limiting ticks, take #2

781e6cf

more info

3ecd71e

fix test_replay_stage_poh_error_entry_receiver

eb66c8a

fix leader_scheduler::test_update_height

c9fcaaf

rob-solana force-pushed the checkpoints_4 branch from 4030e52 to c9fcaaf Compare February 6, 2019 18:49

rob-solana added 3 commits February 6, 2019 11:16

s/bank_state/bank_fork/g

bc131a6

s/bank_checkpoint/bank_delta/g

70c7d69

fix up stragglers from rename

161f9f5

rob-solana mentioned this pull request Feb 7, 2019

Add support for multiple forks to the bank #2689

Closed

3 tasks

garious reviewed Feb 7, 2019

View reviewed changes

garious closed this Feb 8, 2019

wen-coding added a commit to wen-coding/solana that referenced this pull request Aug 25, 2024

Enable wen restart from command line and update comments. (solana-lab…

c8a839a

…s#2640) Enable wen_restart from command line and update comments.

jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Aug 27, 2024

Enable wen restart from command line and update comments. (solana-lab…

d191c80

…s#2640) Enable wen_restart from command line and update comments.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor bank and track root and live bank checkpoints. #2640

Refactor bank and track root and live bank checkpoints. #2640

aeyakovenko commented Feb 1, 2019 •

edited by garious

Loading

garious Feb 4, 2019

aeyakovenko commented Feb 5, 2019 •

edited

Loading

garious commented Feb 5, 2019

garious Feb 7, 2019

garious commented Feb 7, 2019 •

edited

Loading

garious commented Feb 8, 2019

Refactor bank and track root and live bank checkpoints. #2640

Refactor bank and track root and live bank checkpoints. #2640

Conversation

aeyakovenko commented Feb 1, 2019 • edited by garious Loading

Problem

Summary of Changes

garious Feb 4, 2019

Choose a reason for hiding this comment

aeyakovenko commented Feb 5, 2019 • edited Loading

garious commented Feb 5, 2019

garious Feb 7, 2019

Choose a reason for hiding this comment

garious commented Feb 7, 2019 • edited Loading

garious commented Feb 8, 2019

aeyakovenko commented Feb 1, 2019 •

edited by garious

Loading

aeyakovenko commented Feb 5, 2019 •

edited

Loading

garious commented Feb 7, 2019 •

edited

Loading