This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
feat: add minContextSlot configuration to (almost) all web3.js methods
#26296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveluscher
added
enhancement
steveluscher
commented
Jun 28, 2022
Comment on lines
+301
to
+315
| function extractCommitmentFromConfig<TConfig>( | ||
| commitmentOrConfig?: Commitment | ({commitment?: Commitment} & TConfig), | ||
| ) { | ||
| let commitment: Commitment | undefined; | ||
| let config: Omit<TConfig, 'commitment'> | undefined; | ||
| if (typeof commitmentOrConfig === 'string') { | ||
| commitment = commitmentOrConfig; | ||
| } else if (commitmentOrConfig) { | ||
| const {commitment: specifiedCommitment, ...specifiedConfig} = | ||
| commitmentOrConfig; | ||
| commitment = specifiedCommitment; | ||
| config = specifiedConfig; | ||
| } | ||
| return {commitment, config}; | ||
| } |
There was a problem hiding this comment.
This should have been in a separate commit for the purpose of review, sorry.
Codecov Report
@@ Coverage Diff @@
## master #26296 +/- ##
=========================================
+ Coverage 75.7% 75.9% +0.2%
=========================================
Files 40 40
Lines 2350 2358 +8
Branches 340 338 -2
=========================================
+ Hits 1781 1792 +11
+ Misses 450 449 -1
+ Partials 119 117 -2 |
|
|
Totally. Let me do that properly in a separate PR. |
|
PR'd up in #26318. |
This was referenced Aug 3, 2022
This was referenced Aug 6, 2022
This was referenced Aug 19, 2022
This was referenced Aug 26, 2022
This was referenced Sep 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A new config param was added that lets you perform API calls while enforcing that the receiving RPC must have proceeded past a given slot. This API needs to be added to web3.js
Summary of Changes
Fixes #26276.