This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Cleanup fork selection design #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeyakovenko
requested review from
carllin,
garious,
rob-solana and
ericlwilliams
garious
approved these changes
Jan 30, 2019
rob-solana
approved these changes
Jan 30, 2019
ericlwilliams
approved these changes
Jan 30, 2019
aeyakovenko
added
the
automerge
|
💔 Unable to automerge due to CI failure |
solana-grimes
removed
the
automerge
aeyakovenko
force-pushed
the
cleanup_fork_selection
branch
from
1ff7c91 to
9d919de
Compare
aeyakovenko
added
the
automerge
solana-grimes
removed
the
automerge
|
💔 Unable to automerge due to CI failure |
|
@garious, merge or fight CI? |
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Aug 15, 2024
vovkman
pushed a commit
to helius-labs/solana
that referenced
this pull request
Aug 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fork selection book chapter should be more explicit about the problems it solves.
Summary of Changes
Cleanup. Add the material from the slides.
Fixes #