Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

fix typo: BlockheightBasedTransactionConfimationStrategy, Confimation => Confirmation #25279

Merged
merged 2 commits into from
May 17, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions web3.js/src/connection.ts
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ export type BlockhashWithExpiryBlockHeight = Readonly<{
* A strategy for confirming transactions that uses the last valid
* block height for a given blockhash to check for transaction expiration.
*/
export type BlockheightBasedTransactionConfimationStrategy = {
export type BlockheightBasedTransactionConfirmationStrategy = {
signature: TransactionSignature;
} & BlockhashWithExpiryBlockHeight;

Expand Down Expand Up @@ -2842,7 +2842,7 @@ export class Connection {
}

confirmTransaction(
strategy: BlockheightBasedTransactionConfimationStrategy,
strategy: BlockheightBasedTransactionConfirmationStrategy,
commitment?: Commitment,
): Promise<RpcResponseAndContext<SignatureResult>>;

Expand All @@ -2856,7 +2856,7 @@ export class Connection {
// eslint-disable-next-line no-dupe-class-members
async confirmTransaction(
strategy:
| BlockheightBasedTransactionConfimationStrategy
| BlockheightBasedTransactionConfirmationStrategy
| TransactionSignature,
commitment?: Commitment,
): Promise<RpcResponseAndContext<SignatureResult>> {
Expand All @@ -2865,7 +2865,8 @@ export class Connection {
if (typeof strategy == 'string') {
rawSignature = strategy;
} else {
const config = strategy as BlockheightBasedTransactionConfimationStrategy;
const config =
strategy as BlockheightBasedTransactionConfirmationStrategy;
rawSignature = config.signature;
}

Expand Down Expand Up @@ -2942,7 +2943,8 @@ export class Connection {
timeoutMs,
);
} else {
let config = strategy as BlockheightBasedTransactionConfimationStrategy;
let config =
strategy as BlockheightBasedTransactionConfirmationStrategy;
(async () => {
let currentBlockHeight = await checkBlockHeight();
if (done) return;
Expand Down
12 changes: 6 additions & 6 deletions web3.js/src/util/send-and-confirm-raw-transaction.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type {Buffer} from 'buffer';

import {
BlockheightBasedTransactionConfimationStrategy,
BlockheightBasedTransactionConfirmationStrategy,
Connection,
} from '../connection';
import type {TransactionSignature} from '../transaction';
Expand All @@ -14,14 +14,14 @@ import type {ConfirmOptions} from '../connection';
*
* @param {Connection} connection
* @param {Buffer} rawTransaction
* @param {BlockheightBasedTransactionConfimationStrategy} confirmationStrategy
* @param {BlockheightBasedTransactionConfirmationStrategy} confirmationStrategy
* @param {ConfirmOptions} [options]
* @returns {Promise<TransactionSignature>}
*/
export async function sendAndConfirmRawTransaction(
connection: Connection,
rawTransaction: Buffer,
confirmationStrategy: BlockheightBasedTransactionConfimationStrategy,
confirmationStrategy: BlockheightBasedTransactionConfirmationStrategy,
options?: ConfirmOptions,
): Promise<TransactionSignature>;

Expand All @@ -41,13 +41,13 @@ export async function sendAndConfirmRawTransaction(
connection: Connection,
rawTransaction: Buffer,
confirmationStrategyOrConfirmOptions:
| BlockheightBasedTransactionConfimationStrategy
| BlockheightBasedTransactionConfirmationStrategy
| ConfirmOptions
| undefined,
maybeConfirmOptions?: ConfirmOptions,
): Promise<TransactionSignature> {
let confirmationStrategy:
| BlockheightBasedTransactionConfimationStrategy
| BlockheightBasedTransactionConfirmationStrategy
| undefined;
let options: ConfirmOptions | undefined;
if (
Expand All @@ -58,7 +58,7 @@ export async function sendAndConfirmRawTransaction(
)
) {
confirmationStrategy =
confirmationStrategyOrConfirmOptions as BlockheightBasedTransactionConfimationStrategy;
confirmationStrategyOrConfirmOptions as BlockheightBasedTransactionConfirmationStrategy;
options = maybeConfirmOptions;
} else {
options = confirmationStrategyOrConfirmOptions as
Expand Down