This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
fix: mark the socket as closed when receiving a close/error message #25180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveluscher
commented
May 13, 2022
| @@ -4174,13 +4174,15 @@ export class Connection { | |||
| * @internal | |||
| */ | |||
| _wsOnError(err: Error) { | |||
| this._rpcWebSocketConnected = false; | |||
There was a problem hiding this comment.
MDN says:
The error event is fired when a connection with a WebSocket has been closed due to an error (some data couldn't be sent for example).
Codecov Report
@@ Coverage Diff @@
## master solana-labs/solana#25180 +/- ##
=========================================
+ Coverage 75.1% 75.2% +0.1%
=========================================
Files 38 38
Lines 2243 2245 +2
Branches 323 323
=========================================
+ Hits 1686 1690 +4
+ Misses 444 443 -1
+ Partials 113 112 -1 |
jstarry
approved these changes
May 13, 2022
|
I think you're right about this being the root problem, nice! |
This was referenced Jun 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In solana-labs/solana-web3.js#1177 @awojciak noticed that the subscriptions manager would keep trying to slam a closed socket with requests. I believe this is because we were not properly marking the socket as closed when receiving a
'close'event.Summary of Changes
Toggle the connectedness flag when we get a close/error event.
Fixes solana-labs/solana-web3.js#1177.