fix: update method name and fix test timeout issue #24757
Conversation
There was a problem hiding this comment.
What did you think about @t-nelson's feedback that this method belongs on belongs on MessageConnection and should take a Message as input?
Rust SDK: https://docs.rs/solana-client/latest/solana_client/rpc_client/struct.RpcClient.html#method.get_fee_for_message
JSON API: https://docs.solana.com/developing/clients/jsonrpc-api#getfeeformessage
| @@ -490,7 +490,7 @@ export class Transaction { | |||
| /** | |||
| * Get the estimated fee associated with a transaction | |||
| */ | |||
| async getEstimatedFee(connection: Connection): Promise<number> { | |||
| async getFeeForMessage(connection: Connection): Promise<number> { | |||
There was a problem hiding this comment.
Because this is live, we have little choice but to support the old name for a while, deprecated. If you landed this PR, anyone calling getEstimatedFee would find their software no longer compiles with TypeScript (at best) or works in production (at worst).
Rename it, but also create a new method with the old name, that just calls straight through to the one with the new name.
There was a problem hiding this comment.
Okay, will do!
nice save 😉 |
|
Hey, at least I owned up to it. 🤣 |
mergify
bot
dismissed
steveluscher’s stale review
Pull request has been modified.
marcnjaramillo
force-pushed
the
update-transaction-test
branch
2 times, most recently
from
133e01b to
7889487
Compare
marcnjaramillo
force-pushed
the
update-transaction-test
branch
from
4510f95 to
a3c8304
Compare
|
I can't seem to resolve the |
marcnjaramillo
force-pushed
the
update-transaction-test
branch
from
446732b to
e47c6a9
Compare
|
Fixed with #25210 |
Problem
Summary of Changes
Fixes #
#24730