This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
restore existing overlapping overflow #24010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordaaash
pushed a commit
to jordaaash/solana
that referenced
this pull request
Apr 1, 2022
ngundotra
pushed a commit
to ngundotra/solana
that referenced
this pull request
Apr 2, 2022
ngundotra
pushed a commit
to ngundotra/solana
that referenced
this pull request
Apr 2, 2022
ngundotra
pushed a commit
to ngundotra/solana
that referenced
this pull request
Apr 2, 2022
jordaaash
added a commit
that referenced
this pull request
Apr 16, 2022
… key order (#23720) * fix: transaction populate * chore: web3: fix tx serialization test * chore: web3: run prettier * fix: web3: transaction populate * fix: web3: handle nonce info * add hash calc config.use_write_cache (#24005) * restore existing overlapping overflow (#24010) * Stringify populated transaction fields * fix: web3: compare stringified JSON * chore: web3: remove eslint indent rule that conflicts with prettier * fix: web3: explicitly call toJSON * fix: web3: add test for compileMessage * fix: web3: make JSON internal * fix: web3: connection simulation from message relies on mutating transaction Co-authored-by: Jeff Washington (jwash) <wash678@gmail.com> Co-authored-by: Jack May <jack@solana.com> Co-authored-by: Justin Starry <justin@solana.com>
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
… key order (solana-labs#23720) * fix: transaction populate * chore: web3: fix tx serialization test * chore: web3: run prettier * fix: web3: transaction populate * fix: web3: handle nonce info * add hash calc config.use_write_cache (solana-labs#24005) * restore existing overlapping overflow (solana-labs#24010) * Stringify populated transaction fields * fix: web3: compare stringified JSON * chore: web3: remove eslint indent rule that conflicts with prettier * fix: web3: explicitly call toJSON * fix: web3: add test for compileMessage * fix: web3: make JSON internal * fix: web3: connection simulation from message relies on mutating transaction Co-authored-by: Jeff Washington (jwash) <wash678@gmail.com> Co-authored-by: Jack May <jack@solana.com> Co-authored-by: Justin Starry <justin@solana.com>
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Jun 30, 2022
… key order (solana-labs#23720) * fix: transaction populate * chore: web3: fix tx serialization test * chore: web3: run prettier * fix: web3: transaction populate * fix: web3: handle nonce info * add hash calc config.use_write_cache (solana-labs#24005) * restore existing overlapping overflow (solana-labs#24010) * Stringify populated transaction fields * fix: web3: compare stringified JSON * chore: web3: remove eslint indent rule that conflicts with prettier * fix: web3: explicitly call toJSON * fix: web3: add test for compileMessage * fix: web3: make JSON internal * fix: web3: connection simulation from message relies on mutating transaction Co-authored-by: Jeff Washington (jwash) <wash678@gmail.com> Co-authored-by: Jack May <jack@solana.com> Co-authored-by: Justin Starry <justin@solana.com>
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Jun 30, 2022
… key order (solana-labs#23720) * fix: transaction populate * chore: web3: fix tx serialization test * chore: web3: run prettier * fix: web3: transaction populate * fix: web3: handle nonce info * add hash calc config.use_write_cache (solana-labs#24005) * restore existing overlapping overflow (solana-labs#24010) * Stringify populated transaction fields * fix: web3: compare stringified JSON * chore: web3: remove eslint indent rule that conflicts with prettier * fix: web3: explicitly call toJSON * fix: web3: add test for compileMessage * fix: web3: make JSON internal * fix: web3: connection simulation from message relies on mutating transaction Co-authored-by: Jeff Washington (jwash) <wash678@gmail.com> Co-authored-by: Jack May <jack@solana.com> Co-authored-by: Justin Starry <justin@solana.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Original behavior overflowed and was fixed via a feature. A previous pr changed the original behavior
Summary of Changes
Return to previous behavior until the feature is activated
Fixes #