This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
fix: repair web3 connection tests by making fewer assumptions about the existence of particular blocks #23921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
March 24, 2022 15:08
steveluscher
requested review from
joncinque and
jordaaash
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #23921 +/- ##
===========================================
- Coverage 81.8% 70.0% -11.8%
===========================================
Files 581 36 -545
Lines 158312 2217 -156095
Branches 0 311 +311
===========================================
- Hits 129518 1553 -127965
+ Misses 28794 557 -28237
- Partials 0 107 +107 |
steveluscher
force-pushed
the
early-blocks-cant-live-with-em-cant-live-without-em
branch
from
5b6c18c to
aca4e35
Compare
steveluscher
deleted the
early-blocks-cant-live-with-em-cant-live-without-em
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In short, there was a change to the local test validator that made blocks 0 and 1 – in particular – inaccessible (see #23853). Our web3.js tests, on the other hand, presumed a lot about the presence of those particular blocks.
In this PR, we do one of two things to those tests. Either we eliminate the presumption that a block related to a particular numbered slot exists if it doesn't really matter what that number is, or we handle the absence of such a block if we're truly making assertions about a particular blocking in a particular slot.
This PR supecedes #23789.
Fixes #23615 (partially).