This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Implement forwarding via TpuConnection #23817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
reviewed
Mar 21, 2022
sakridge
reviewed
Mar 21, 2022
sakridge
reviewed
Mar 21, 2022
t-nelson
reviewed
Mar 21, 2022
lijunwangs
reviewed
Mar 22, 2022
ryleung-solana
force-pushed
the
quic-forwarding
branch
from
3333024 to
4f1bc56
Compare
t-nelson
reviewed
Mar 23, 2022
client/src/connection_cache.rs
Outdated
| @@ -13,9 +14,15 @@ use { | |||
| // Should be non-zero | |||
| static MAX_CONNECTIONS: usize = 64; | |||
|
|
|||
| #[derive(Clone)] | |||
| enum Connection { | |||
There was a problem hiding this comment.
try to avoid doing these refactors in unrelated change sets. it makes review unnecessarily time consuming
client/src/tpu_connection.rs
Outdated
|
|
||
| fn par_serialize_and_send_transaction_batch( | ||
| &self, | ||
| transaction_batch: &[VersionedTransaction], | ||
| transactions: &[VersionedTransaction], |
core/src/voting_service.rs
Outdated
| @@ -90,7 +90,7 @@ impl VotingService { | |||
|
|
|||
| let mut measure = Measure::start("vote_tx_send-ms"); | |||
| let target_address = target_address.unwrap_or_else(|| cluster_info.my_contact_info().tpu); | |||
| let _ = get_connection(&target_address).serialize_and_send_transaction(vote_op.tx()); | |||
| let _ = serialize_and_send_transaction(vote_op.tx(), &target_address); | |||
There was a problem hiding this comment.
there's a merge conflict here against changes that Pankaj and Justin put in yesterday
| 1000 | ||
| ); | ||
|
|
||
| if let Err(err) = res { |
There was a problem hiding this comment.
could res.is_err() here and avoid de/restructuring
|
|
||
| measure.stop(); | ||
| inc_new_counter_info!( | ||
| "banking_stage-forward-us", |
There was a problem hiding this comment.
Suggested change
| "banking_stage-forward-us", | |
| "banking_stage-forward-send-us", |
ryleung-solana
force-pushed
the
quic-forwarding
branch
from
e2f566e to
084c4ab
Compare
ryleung-solana
force-pushed
the
quic-forwarding
branch
from
084c4ab to
29496c1
Compare
sakridge
approved these changes
Mar 25, 2022
mergify bot
pushed a commit
that referenced
this pull request
Mar 25, 2022
(cherry picked from commit 6b85c21)
sakridge
pushed a commit
that referenced
this pull request
Mar 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to forward transactions using Quic.
Summary of Changes
Changes packet forwarding to use the TpuConnection and the connection cache, so it can be switched between UDP and Quic.
Fixes #