Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Nits in message-processor #21755

Merged
merged 2 commits into from
Dec 10, 2021

Conversation

CriesofCarrots
Copy link
Contributor

Problem

When exploring #21142, discovered a couple nits:

  • a typo in variable name
  • complex return type that makes working with account RefCells before and after message processing difficult

Summary of Changes

No functionality change (therefore backporting to stable)

  • Fix typo
  • Add type alias to simplify types

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #21755 (0df8560) into master (0224a8b) will decrease coverage by 0.1%.
The diff coverage is 74.1%.

@@            Coverage Diff            @@
##           master   #21755     +/-   ##
=========================================
- Coverage    81.6%    81.4%   -0.2%     
=========================================
  Files         511      511             
  Lines      143320   143469    +149     
=========================================
- Hits       116976   116825    -151     
- Misses      26344    26644    +300     

@CriesofCarrots CriesofCarrots merged commit c1386d6 into solana-labs:master Dec 10, 2021
mergify bot pushed a commit that referenced this pull request Dec 10, 2021
* Fixup typo

* Simplify types slightly

(cherry picked from commit c1386d6)

# Conflicts:
#	runtime/src/bank.rs
#	runtime/src/message_processor.rs
mergify bot pushed a commit that referenced this pull request Dec 10, 2021
* Fixup typo

* Simplify types slightly

(cherry picked from commit c1386d6)
jstarry pushed a commit that referenced this pull request Dec 10, 2021
* Fixup typo

* Simplify types slightly

(cherry picked from commit c1386d6)

Co-authored-by: Tyera Eulberg <teulberg@gmail.com>
mergify bot added a commit that referenced this pull request Dec 10, 2021
* Nits in message-processor (#21755)

* Fixup typo

* Simplify types slightly

(cherry picked from commit c1386d6)

# Conflicts:
#	runtime/src/bank.rs
#	runtime/src/message_processor.rs

* Fix conflicts

* Use alias more broadly

Co-authored-by: Tyera Eulberg <teulberg@gmail.com>
Co-authored-by: Tyera Eulberg <tyera@solana.com>
t-nelson added a commit to t-nelson/solana that referenced this pull request Dec 13, 2021
tao-stones pushed a commit that referenced this pull request Dec 13, 2021
CriesofCarrots pushed a commit to CriesofCarrots/solana that referenced this pull request Dec 16, 2021
CriesofCarrots pushed a commit that referenced this pull request Dec 17, 2021
@brooksprumo brooksprumo mentioned this pull request Jan 5, 2022
@CriesofCarrots CriesofCarrots deleted the processor-nits branch February 26, 2022 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant