This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Nits in message-processor #21755
Merged
CriesofCarrots
merged 2 commits into
solana-labs:master
from
CriesofCarrots:processor-nits
Dec 10, 2021
Merged
Nits in message-processor #21755
CriesofCarrots
merged 2 commits into
solana-labs:master
from
CriesofCarrots:processor-nits
Dec 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ed9c97
to
0df8560
Compare
Codecov Report
@@ Coverage Diff @@
## master #21755 +/- ##
=========================================
- Coverage 81.6% 81.4% -0.2%
=========================================
Files 511 511
Lines 143320 143469 +149
=========================================
- Hits 116976 116825 -151
- Misses 26344 26644 +300 |
mergify bot
pushed a commit
that referenced
this pull request
Dec 10, 2021
* Fixup typo * Simplify types slightly (cherry picked from commit c1386d6) # Conflicts: # runtime/src/bank.rs # runtime/src/message_processor.rs
mergify bot
pushed a commit
that referenced
this pull request
Dec 10, 2021
* Fixup typo * Simplify types slightly (cherry picked from commit c1386d6)
jstarry
pushed a commit
that referenced
this pull request
Dec 10, 2021
mergify bot
added a commit
that referenced
this pull request
Dec 10, 2021
* Nits in message-processor (#21755) * Fixup typo * Simplify types slightly (cherry picked from commit c1386d6) # Conflicts: # runtime/src/bank.rs # runtime/src/message_processor.rs * Fix conflicts * Use alias more broadly Co-authored-by: Tyera Eulberg <teulberg@gmail.com> Co-authored-by: Tyera Eulberg <tyera@solana.com>
t-nelson
added a commit
to t-nelson/solana
that referenced
this pull request
Dec 13, 2021
…a-labs#21761)" This reverts commit 87c7164.
tao-stones
pushed a commit
that referenced
this pull request
Dec 13, 2021
CriesofCarrots
pushed a commit
to CriesofCarrots/solana
that referenced
this pull request
Dec 16, 2021
solana-labs#21761)"" This reverts commit d3e92f4.
CriesofCarrots
pushed a commit
that referenced
this pull request
Dec 17, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When exploring #21142, discovered a couple nits:
Summary of Changes
No functionality change (therefore backporting to stable)