This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
stabilize testing with --test-threads=1 #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Boo. What's so hard about moving all the poorly written tests? |
|
not hard, it just takes longer. also, I don't think it's just that. I see some real wonkiness when we try to multiply instantiate rpc servers and use keep-alive clients (e.g. 100s of LWPs consuming 100% of the CPU, with the top offenders buried deep in the server library) |
rob-solana
force-pushed
the
test-threads=1
branch
from
b9f2e18 to
eed8c5f
Compare
|
cc #1959 |
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
…olana-labs#1954) Bumps [flow-bin](https://github.com/flowtype/flow-bin) from 0.145.0 to 0.154.0. - [Release notes](https://github.com/flowtype/flow-bin/releases) - [Commits](https://github.com/flowtype/flow-bin/commits) --- updated-dependencies: - dependency-name: flow-bin dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
andreisilviudragnea
pushed a commit
to andreisilviudragnea/solana
that referenced
this pull request
Jul 2, 2024
* Refactor and additional metrics for cost tracking (solana-labs#1888) * Refactor and add metrics: - Combine remove_* and update_* functions to reduce locking on cost-tracker and iteration. - Add method to calculate executed transaction cost by directly using actual execution cost and loaded accounts size; - Wireup histogram to report loaded accounts size; - Report time of block limits checking; - Move account counters from ExecuteDetailsTimings to ExecuteAccountsDetails; * Move committed transactions adjustment into its own function * remove histogram for loaded accounts size due to performance impact
yihau
pushed a commit
to yihau/solana
that referenced
this pull request
Jul 18, 2024
…abs#1975) * Refactor cost tracking (solana-labs#1954) * Refactor and additional metrics for cost tracking (solana-labs#1888) * Refactor and add metrics: - Combine remove_* and update_* functions to reduce locking on cost-tracker and iteration. - Add method to calculate executed transaction cost by directly using actual execution cost and loaded accounts size; - Wireup histogram to report loaded accounts size; - Report time of block limits checking; - Move account counters from ExecuteDetailsTimings to ExecuteAccountsDetails; * Move committed transactions adjustment into its own function * remove histogram for loaded accounts size due to performance impact (cherry picked from commit f8630a3) * rename cost_tracker.account_data_size to better describe its purpose is to tracker per-block new account allocation --------- Co-authored-by: Tao Zhu <82401714+tao-stones@users.noreply.github.com> Co-authored-by: Tao Zhu <tao@solana.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
many of our tests start servers that do no co-exist gracefully, until these tessts are moved or the code that creates the co-existence issues is fixed, run CI in single-threaded mode
Summary of Changes
ci/test-stable.sh to test main lib of solana in single-threaded mode
Fixes #