Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Don't skip shrink #19350

Closed
wants to merge 1 commit into from
Closed

Conversation

sakridge
Copy link
Contributor

Problem

See if skipping shrink has an affect on #19320

Summary of Changes

Fixes #

@sakridge sakridge force-pushed the no-skip-shrink-1.7 branch from 9354cd0 to 3688eaf Compare August 20, 2021 19:17
@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #19350 (3688eaf) into v1.7 (1c9d052) will decrease coverage by 0.0%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             v1.7   #19350     +/-   ##
=========================================
- Coverage    82.4%    82.3%   -0.1%     
=========================================
  Files         436      436             
  Lines      123651   123632     -19     
=========================================
- Hits       101898   101847     -51     
- Misses      21753    21785     +32     

@carllin
Copy link
Contributor

carllin commented Aug 23, 2021

Looks like we may want to delete

&& Self::is_shrinking_productive(*slot, &[store.clone()])
as well to be complete in the removal of this logic.

@sakridge sakridge closed this Aug 27, 2021
@sakridge sakridge deleted the no-skip-shrink-1.7 branch August 27, 2021 09:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants