-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize some CI stuff #1880
Optimize some CI stuff #1880
Conversation
Was able to knock 4 minutes off of overall CI by localizing the feature builds to stable-perf (which we should probably label But bench was still taking 26 minutes to build, all of it essentially here: I tried it without docker and the times went down to 15 minutes! Since buildkite runs in parallel, the overall time it takes for CI to finish is the longest task. The 2nd running task is We could probably save even more by either balancing out work amount the other buildkite tasks or creating additional buildkite tasks to parallelize the load. The results are in the following build: https://buildkite.com/solana-labs/solana/builds/5239 |
Got more concrete times on beta, something is weird because I would not expect beta to take this much longer, maybe beta itself is not optimized, or built as release, or something.
The results are in the following build: https://buildkite.com/solana-labs/solana/builds/5243 |
@mvines Let me know what you think |
…-labs#1872) (solana-labs#1880) spl: Upgrade all crates to v2-only versions (solana-labs#1872) (cherry picked from commit 6aee845) Co-authored-by: Jon C <me@jonc.dev>
Problem
Summary of Changes
-jobs
was being used but that only affects how many threads are used to build the tests. We want many threads building but only one thread running a test at a time. Changed from-jobs
to--test-threads
. This means we build fast but run each test sequentially in a single thread.cargo bench
command is taking pretty much the entire ~15 mins. Could split that out into multiple Buildkite tasks and do them in parallel.More details in the comments below...
Fixes #