This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Banking stage offload cost model to sep thread #18275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cost_model_thread so the cost tracking is done offline.
… after committed to bank, avoiding cloning individual `transaction` when send.
tao-stones
force-pushed
the
banking_stage_offload_cost_model_to_sep_thread
branch
from
a7a14a3 to
d3c3412
Compare
This was referenced Apr 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently banking_stage runs cost model logic inline in its main threads. This inline-ness may not be necessary, cost can be tracked on separate thread to minimize overhead to banking main threads.
Summary of Changes
cost_model_threadto banking_stagetransactiontocost_model_threadfor off-line cost tracking.Fixes #