This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
runtime: add rent debit charges to block metadata #17504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-nelson
force-pushed
the
rent-debit-block-metas
branch
from
ed0d3e5 to
c5faff8
Compare
CriesofCarrots
previously approved these changes
May 26, 2021
|
Added some tests for |
mergify
bot
dismissed
CriesofCarrots’s stale review
Pull request has been modified.
t-nelson
added
the
automerge
ryoqun
reviewed
May 26, 2021
| // Store all of them unconditionally to purge old AppendVec, | ||
| // even if collected rent is 0 (= not updated). | ||
| // Also, there's another subtle side-effect from this: this | ||
| // ensures we verify the whole on-chain state (= all accounts) | ||
| // via the account delta hash slowly once per an epoch. | ||
| self.store_account(&pubkey, &account); | ||
| rent_debits.push(&pubkey, rent, account.lamports()); |
mergify
bot
removed
the
automerge
|
automerge label removed due to a CI failure |
t-nelson
force-pushed
the
rent-debit-block-metas
branch
from
bb844e4 to
ceb6f42
Compare
t-nelson
added
the
automerge
mergify
bot
removed
the
automerge
|
automerge label removed due to a CI failure |
t-nelson
added
the
automerge
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It is difficult to resolve rent debits from block metadata alone
Summary of Changes
Add explicit rent debit entries in block metadata