This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
patches flaky test_new_mark_creation_time #17288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17288 +/- ##
=======================================
Coverage 82.7% 82.7%
=======================================
Files 421 421
Lines 118023 118030 +7
=======================================
+ Hits 97638 97659 +21
+ Misses 20385 20371 -14 |
mergify bot
pushed a commit
that referenced
this pull request
May 19, 2021
(cherry picked from commit f7b0184)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
test_new_mark_creation_timeis probabilistic by design and might sometimes fail:https://github.com/solana-labs/solana/blob/d1db5448b/core/src/crds_gossip_pull.rs#L1047
Summary of Changes
accounted for 1% chance of the test failing.