This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Rpc: populate block-time for confirmed transactions #16460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
added
v1.5
automerge
Codecov Report
@@ Coverage Diff @@
## master #16460 +/- ##
=========================================
- Coverage 80.0% 79.9% -0.1%
=========================================
Files 413 413
Lines 110636 110637 +1
=========================================
- Hits 88523 88489 -34
- Misses 22113 22148 +35 |
mergify bot
pushed a commit
that referenced
this pull request
Apr 9, 2021
(cherry picked from commit 8bc0bdd)
mergify bot
pushed a commit
that referenced
this pull request
Apr 9, 2021
(cherry picked from commit 8bc0bdd)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The CacheBlockTimeService runs when a block is rooted. This means that confirmed, but not finalized, transactions returned from Blockstore usually do not have populated block times. Since banks are held in BankForks until finalized, these block times should be available there.
Summary of Changes
Following #16281, look up block times for not-yet-finalized transactions