This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Add memory operation syscalls #16447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackcmay
force-pushed
the
mem-op-syscalls
branch
from
999da34 to
f146bc8
Compare
Codecov Report
@@ Coverage Diff @@
## master #16447 +/- ##
=========================================
- Coverage 82.7% 82.6% -0.1%
=========================================
Files 426 427 +1
Lines 119417 119533 +116
=========================================
+ Hits 98793 98826 +33
- Misses 20624 20707 +83 |
|
Is this going to be merged soon? Once this is merged I can release a new version of bpf-tools that uses the memory operations syscalls |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
stale
stale
bot
removed
the
stale
dmakarov
approved these changes
Jun 1, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jun 1, 2021
(cherry picked from commit 2b50529) # Conflicts: # programs/bpf/Cargo.lock
jackcmay
added a commit
that referenced
this pull request
Jun 2, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jun 22, 2021
(cherry picked from commit 2b50529) # Conflicts: # programs/bpf/Cargo.lock # programs/bpf/rust/sysvar/tests/lib.rs # programs/bpf/tests/programs.rs # programs/bpf_loader/src/syscalls.rs # sdk/src/feature_set.rs
mergify bot
added a commit
that referenced
this pull request
Jun 22, 2021
* Add memory operation syscalls (#16447) (cherry picked from commit 2b50529) # Conflicts: # programs/bpf/Cargo.lock # programs/bpf/rust/sysvar/tests/lib.rs # programs/bpf/tests/programs.rs # programs/bpf_loader/src/syscalls.rs # sdk/src/feature_set.rs * resolve conflicts Co-authored-by: Jack May <jack@solana.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Large repetitive memory operations (memcpy) are expensive in BPF
Summary of Changes
Fixes #