This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Setup ReplayStage confirmation scaffolding for duplicate slots (bp #9698) #16119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
mergify
bot
added
the
automerge
carllin
force-pushed
the
mergify/bp/v1.6/pr-9698
branch
from
44c9dea to
6cb47de
Compare
|
😱 New commits were pushed while the automerge label was present. |
solana-grimes
removed
the
automerge
mergify
bot
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## v1.6 #16119 +/- ##
=========================================
+ Coverage 79.8% 80.0% +0.1%
=========================================
Files 409 410 +1
Lines 107963 109009 +1046
=========================================
+ Hits 86246 87211 +965
- Misses 21717 21798 +81 |
(cherry picked from commit 52703ba)
t-nelson
force-pushed
the
mergify/bp/v1.6/pr-9698
branch
from
6cb47de to
880182c
Compare
|
😱 New commits were pushed while the automerge label was present. |
solana-grimes
removed
the
automerge
t-nelson
reviewed
Mar 30, 2021
Comment on lines
1457
to
+1459
| &mut true, | ||
| &mut Vec::new(), | ||
| &mut BTreeMap::new(), |
There was a problem hiding this comment.
This new BTreeMap friend comes after bool and Vec friends now. Plumbed like this throughout
Comment on lines
-1436
to
-1438
| if let Some(transaction_status_sender) = transaction_status_sender.clone() { | ||
| transaction_status_sender.send_transaction_status_freeze_message(&bank); | ||
| } |
There was a problem hiding this comment.
This if-statement wasn't in the original delete block, so I added it to the addition block below
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #9698 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/