Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

rpc: Add config options limiting getConfirmedBlock response data (bp #15970) #15994

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 18, 2021

This is an automatic backport of pull request #15970 done by Mergify.

Cherry-pick of aa54c46 has failed:

On branch mergify/bp/v1.5/pr-15970
Your branch is up to date with 'origin/v1.5'.

You are currently cherry-picking commit aa54c468e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   cli/src/stake.rs
	modified:   client/src/rpc_client.rs
	modified:   client/src/rpc_config.rs
	modified:   docs/src/developing/clients/jsonrpc-api.md
	modified:   transaction-status/src/lib.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   core/src/rpc.rs

To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

)

* Add new confirmed block struct

* Add RpcConfirmedBlockConfig options

* Configure block response based on new options

* Add client api, use in cli fetch_epoch_rewards

* Update docs

* Apply review suggestions

(cherry picked from commit aa54c46)

# Conflicts:
#	core/src/rpc.rs
@mergify mergify bot added the conflicts label Mar 18, 2021
@mergify mergify bot added the automerge Merge this Pull Request automatically once CI passes label Mar 18, 2021
@mergify
Copy link
Contributor Author

mergify bot commented Mar 18, 2021

automerge label removed due to a CI failure

@mergify mergify bot added automerge Merge this Pull Request automatically once CI passes and removed automerge Merge this Pull Request automatically once CI passes labels Mar 18, 2021
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #15994 (aadf152) into v1.5 (de8df24) will decrease coverage by 0.0%.
The diff coverage is 64.3%.

@@            Coverage Diff            @@
##             v1.5   #15994     +/-   ##
=========================================
- Coverage    79.4%    79.4%   -0.1%     
=========================================
  Files         405      405             
  Lines      105306   105402     +96     
=========================================
+ Hits        83659    83692     +33     
- Misses      21647    21710     +63     

@mergify mergify bot merged commit a5f8635 into v1.5 Mar 18, 2021
@mergify mergify bot deleted the mergify/bp/v1.5/pr-15970 branch March 18, 2021 20:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge this Pull Request automatically once CI passes conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant