This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Sanitize instruction index when loading instruction from sysvar #15942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
force-pushed
the
sanitize-ix-index
branch
from
e133902 to
c1bd348
Compare
Codecov Report
@@ Coverage Diff @@
## master #15942 +/- ##
=========================================
- Coverage 80.0% 80.0% -0.1%
=========================================
Files 409 409
Lines 106757 106767 +10
=========================================
- Hits 85437 85431 -6
- Misses 21320 21336 +16 |
|
maybe, this needs feature gate? |
I think offenders are already crashing |
This is an sdk method that would be compiled into a bpf binary, not in the runtime afaik |
jstarry
changed the title
|
got a 👍🏻 from @sakridge |
mergify bot
pushed a commit
that referenced
this pull request
Mar 19, 2021
(cherry picked from commit 4c5660b)
mergify bot
pushed a commit
that referenced
this pull request
Mar 19, 2021
(cherry picked from commit 4c5660b)
jstarry
added a commit
that referenced
this pull request
Mar 19, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
sysvar::instructions::load_instruction_atsdk method doesn't sanitize the index when loading an instruction. Context: solana-labs/solana-program-library#1444 (comment)Summary of Changes
Fixes #