Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

CLI: Support dumping the TX message in sign-only mode #15834

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

t-nelson
Copy link
Contributor

Problem

No way to output the binary transaction message with CLI

Summary of Changes

Add a flag to output the base64-encoded transaction message in sign-only mode

Fixes #15786

@t-nelson t-nelson added the v1.5 label Mar 13, 2021
@t-nelson t-nelson force-pushed the cli-dump-message branch 2 times, most recently from 6136416 to 1e6994d Compare March 13, 2021 03:18
@mvines mvines added the v1.6 label Mar 13, 2021
CriesofCarrots
CriesofCarrots previously approved these changes Mar 15, 2021
Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CriesofCarrots
Copy link
Contributor

How do you want to handle updating spl-token-cli?

@mergify mergify bot dismissed CriesofCarrots’s stale review March 16, 2021 17:55

Pull request has been modified.

@t-nelson
Copy link
Contributor Author

How do you want to handle updating spl-token-cli?

I'll do it once 1.5.15 crates are live. So much less plumbing there. The itch to refactor CLI similarly is getting strong now

@CriesofCarrots
Copy link
Contributor

I'll do it once 1.5.15 crates are live. So much less plumbing there. The itch to refactor CLI similarly is getting strong now

Ya, just don't think this will pass downstream-projects due to the return_signers() signature change

@t-nelson
Copy link
Contributor Author

I'll do it once 1.5.15 crates are live. So much less plumbing there. The itch to refactor CLI similarly is getting strong now

Ya, just don't think this will pass downstream-projects due to the return_signers() signature change

Countdown to SPL in monorepo...

@t-nelson
Copy link
Contributor Author

Ya, just don't think this will pass downstream-projects due to the return_signers() signature change

I'm adding a return_signers_with_config(), return_signers() will just wrap it with defaults. Re-plumbing CLI now 🤕

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #15834 (ed4f155) into master (821be88) will decrease coverage by 0.0%.
The diff coverage is 59.8%.

@@            Coverage Diff            @@
##           master   #15834     +/-   ##
=========================================
- Coverage    80.0%    79.9%   -0.1%     
=========================================
  Files         409      409             
  Lines      106389   106636    +247     
=========================================
+ Hits        85163    85303    +140     
- Misses      21226    21333    +107     

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli: Add a flag for outputting raw transaction messages to be signed offline
4 participants