This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Friendlier error message for mapping failures #12213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12213 +/- ##
=========================================
- Coverage 82.1% 82.1% -0.1%
=========================================
Files 338 338
Lines 79577 79585 +8
=========================================
+ Hits 65352 65358 +6
- Misses 14225 14227 +2 |
mergify bot
pushed a commit
that referenced
this pull request
Sep 15, 2020
(cherry picked from commit 3d4b9bb)
|
Thanks, delayed r+! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
panic for mapping error is not very user-friendly and doesn't offer any suggestion for fixing the problem.
Summary of Changes
Print an error offering vm.max_map_count suggestion and exit.
Fixes #12186