Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Perf to influx #1166

Merged
merged 1 commit into from
Sep 19, 2018
Merged

Perf to influx #1166

merged 1 commit into from
Sep 19, 2018

Conversation

sakridge
Copy link
Contributor

@sakridge sakridge commented Sep 9, 2018

No description provided.

@sakridge sakridge force-pushed the perf-to-influx branch 2 times, most recently from 4962d63 to dde3867 Compare September 9, 2018 04:10
@sakridge sakridge added the work in progress This isn't quite right yet label Sep 10, 2018
@sakridge
Copy link
Contributor Author

Maybe fixes #383

@garious
Copy link
Contributor

garious commented Sep 19, 2018

@sakridge, anything going on with this one? Maybe just dump the text file instead and then use benchcmp to compare them in CI in a separate PR?

@sakridge sakridge force-pushed the perf-to-influx branch 2 times, most recently from d44d74a to 5132f7c Compare September 19, 2018 19:52
@sakridge sakridge removed the work in progress This isn't quite right yet label Sep 19, 2018
@sakridge sakridge merged commit 2981076 into solana-labs:master Sep 19, 2018
@sakridge sakridge deleted the perf-to-influx branch September 19, 2018 20:17
vkomenda pushed a commit to vkomenda/solana that referenced this pull request Aug 29, 2021
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.12.10 to 7.12.13.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.12.13/packages/babel-core)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
TESLA-SATI pushed a commit to TESLA-SATI/solana that referenced this pull request May 3, 2024
`unwrap_err()` does not contain a descriptive message for the case when
it succeeds.  It may help someone debugging the test, in particular they
will see a short explanation without looking at the failed test.

Also, in a number of cases, `unwrap_err()` result was not checked,
creating a possibility for false positives.  As the generated error
might be different from the one expected by the test author.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants