Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Abort if the open fd limit cannot be increased #10064

Merged
merged 1 commit into from
May 15, 2020

Conversation

mvines
Copy link
Contributor

@mvines mvines commented May 15, 2020

While we emit an error log when the fd limit can't be increased, the validator/ledger-tool still trucks on and will likely generate an unexpected failure sometime later in execution. Better to fail fast and make the user deal with the issue up front.

t-nelson
t-nelson previously approved these changes May 15, 2020
Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mergify mergify bot dismissed t-nelson’s stale review May 15, 2020 17:30

Pull request has been modified.

@mvines mvines added the automerge Merge this Pull Request automatically once CI passes label May 15, 2020
@solana-grimes solana-grimes merged commit 7080fb9 into solana-labs:master May 15, 2020
mergify bot pushed a commit that referenced this pull request May 15, 2020
automerge

(cherry picked from commit 7080fb9)

# Conflicts:
#	ledger/src/blockstore_db.rs
mergify bot pushed a commit that referenced this pull request May 15, 2020
automerge

(cherry picked from commit 7080fb9)

# Conflicts:
#	ledger/src/blockstore_db.rs
@mvines mvines deleted the fd branch May 15, 2020 20:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants