Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RPC Wallet API #702

Closed
garious opened this issue Jul 19, 2018 · 5 comments
Closed

Add RPC Wallet API #702

garious opened this issue Jul 19, 2018 · 5 comments
Assignees
@CriesofCarrots
Milestone
v0.8 Windansea

Comments

@garious
Copy link
Contributor

garious commented Jul 19, 2018

RPU UDP-based API should be moved to a REST API so that it'd be straight-forward to add a web-based wallet.
@garious garious added this to the v0.8.0 milestone Jul 19, 2018
@garious garious changed the title REST Wallet API Add REST Wallet API Jul 19, 2018
@garious
Copy link
Contributor Author

garious commented Aug 1, 2018

Here's a potential consumer of that API: https://metamask.io/. Not a requirement to close this ticket, but ideally, we could light up MetaMask with only minor tweaks/extensions after implementing our HTTP API. Please choose an API in the context of at least one popular, potential consumer.

@CriesofCarrots CriesofCarrots changed the title Add REST Wallet API Add RPC Wallet API Aug 7, 2018
@CriesofCarrots
Copy link
Contributor

Based on MetaMask research, plan to use JSON-RPC protocol instead of REST.

@CriesofCarrots
Copy link
Contributor

Maybe both...?

@mvines mvines modified the milestones: v0.8.0, v0.9.0 Aug 9, 2018
@mvines
Copy link
Member

mvines commented Aug 9, 2018

Yeah JSON-RPC seems to be the norm around these parts. I don't think we need both

@mvines
Copy link
Member

mvines commented Aug 11, 2018

I looked into metamask and it only makes sense to interop with metamask, in it's current form, if we choose to implement an eth web3 provider. Doing this boxes us into an eth world, which I don't think we want to do at this time.

@mvines mvines mentioned this issue Aug 12, 2018
Closed
@CriesofCarrots CriesofCarrots mentioned this issue Aug 13, 2018
Merged
@CriesofCarrots CriesofCarrots mentioned this issue Aug 22, 2018
Merged
vkomenda pushed a commit to vkomenda/solana that referenced this issue Aug 29, 2021
@ysavchenko
Interface accounts added as read-only, fixed mint authority on deposi…
100e930 
…t, fixed stake pool stake deserializing (solana-labs#702)
@n4st0r n4st0r mentioned this issue Mar 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CriesofCarrots CriesofCarrots

Labels
None yet
Projects
None yet
Milestone
v0.8 Windansea
Development

No branches or pull requests
3 participants
@garious @mvines @CriesofCarrots