Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Rust BPF: Using customized sysroot requires maintaining a fork #4389

Closed
jackcmay opened this issue May 22, 2019 · 4 comments
Closed

Rust BPF: Using customized sysroot requires maintaining a fork #4389

jackcmay opened this issue May 22, 2019 · 4 comments
Assignees
@dmakarov @jackcmay
Milestone
The Future!

Comments

@jackcmay
Copy link
Contributor

jackcmay commented May 22, 2019 •
edited
Loading

Problem

There are multiple customizations to the Rust sysroot (liballoc, libcore, compiler-builtins, etc...) that require we maintain our own fork/repo. Issues #3101, #3102, multi-thread related features are the most obvious but there are other changes related to interdependencies related to xargo that also require customizing the sysroot Cargo.toml files.

Proposed Solution
@mvines mvines added this to the Waimea v0.17.0 milestone May 28, 2019
@jackcmay jackcmay changed the title Rust BPF: Using customized sysroot requires a maintaining a fork Rust BPF: Using customized sysroot requires maintaining a fork Jul 1, 2019
@jackcmay jackcmay modified the milestones: Waimea v0.17.0, The Future! Jul 2, 2019
@mvines mvines modified the milestones: The Future!, Supertubes v0.22.0 Sep 3, 2019
@mvines mvines modified the milestones: Supertubes v0.22.0, v0.23.0 Nov 25, 2019
@mvines mvines modified the milestones: Tofino v0.23.0, Rincon v0.24.0 Jan 16, 2020
@mvines mvines modified the milestones: Rincon v0.24.0, v0.25.0 Feb 20, 2020
@mvines mvines modified the milestones: v1.1.0, v1.2.0 Mar 30, 2020
@mvines mvines modified the milestones: v1.2.0, The Future! Apr 20, 2020
@stale
Copy link

stale bot commented Apr 20, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Apr 20, 2021
@jackcmay jackcmay self-assigned this Apr 20, 2021
@stale stale bot removed the stale [bot only] Added to stale content; results in auto-close after a week. label Apr 20, 2021
@jackcmay
Copy link
Contributor Author

@dmakarov We can close this now that you've combined the custom sysroot into the tree?

@dmakarov
Copy link
Contributor

Yes.

@jackcmay
Copy link
Contributor Author

Great work @dmakarov , we are no longer dependent on a bunch of forks for the custom sysroot

behzadnouri pushed a commit to behzadnouri/solana that referenced this issue Jan 12, 2025
@yihau
ci: run 5 partitions for tests (solana-labs#4389)
fd5165e 
* ci: run 4 partitions for tests

* run 5

* revert retry update

* reduce the timeout
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dmakarov dmakarov

@jackcmay jackcmay

Labels
None yet
Projects
None yet
Milestone
The Future!
Development

No branches or pull requests
3 participants
@dmakarov @mvines @jackcmay