Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Feature Gate: on accounts hash calculation, do not try to rehash accounts #28934

Open
jeffwashington opened this issue Nov 23, 2022 · 0 comments
Open

Feature Gate: on accounts hash calculation, do not try to rehash accounts #28934

jeffwashington opened this issue Nov 23, 2022 · 0 comments
Labels
feature-gate Pull Request adds or modifies a runtime feature gate

Comments

@jeffwashington
Copy link
Contributor

jeffwashington commented Nov 23, 2022 •
edited by Lichtso
Loading

Description

#28541 was created and activated (on testnet) to restore compatibility of testnet with mnb and master.
#28541 did not cover the case where we rehash accounts with an expected rent_epoch field during accounts hash calculation. As a result, the feature activation was not sufficient to restore compatibility. We have to disable the rehashing with a feature as well on testnet.
This feature on mnb and devnet will do nothing eventually. On testnet, we will activate it and it will change the network's idea of what 'correct' accounts hash values are.

Feature ID

DTVTkmw3JSofd8CJVJte8PXEbxNQ2yZijvVr3pe2APPj

Activation Method

Single Core Contributor

Minimum Beta Version

No response

Minimum Stable Version

No response

Testnet Activation Epoch

394

Devnet Activation Epoch

No response

Mainnet-Beta Activation Epoch

No response
@jeffwashington jeffwashington added the feature-gate Pull Request adds or modifies a runtime feature gate label Nov 23, 2022
@jeffwashington jeffwashington changed the title Feature Gate: on accounst hash calculation, do not try to rehash accounts Feature Gate: on accounts hash calculation, do not try to rehash accounts Nov 23, 2022
jeffwashington added a commit to jeffwashington/solana that referenced this issue Nov 23, 2022
@jeffwashington
add feature solana-labs#28934
4d8b42c
jeffwashington added a commit to jeffwashington/solana that referenced this issue Nov 23, 2022
@jeffwashington
feature: on accounts hash calculation, do not try to rehash accounts s…
02a059a 
…olana-labs#28934
@jeffwashington jeffwashington mentioned this issue Nov 23, 2022
Merged
jeffwashington added a commit to jeffwashington/solana that referenced this issue Nov 23, 2022
@jeffwashington
add feature solana-labs#28934
a90897e
jeffwashington added a commit to jeffwashington/solana that referenced this issue Nov 23, 2022
@jeffwashington
feature: on accounts hash calculation, do not try to rehash accounts s…
624d83d 
…olana-labs#28934
jeffwashington added a commit to jeffwashington/solana that referenced this issue Nov 23, 2022
@jeffwashington
add feature solana-labs#28934 (no-op in master)
eff6a72
jeffwashington added a commit to jeffwashington/solana that referenced this issue Nov 23, 2022
@jeffwashington
feature: on accounts hash calculation, do not try to rehash accounts s…
35ad0d3 
…olana-labs#28934
jeffwashington added a commit to jeffwashington/solana that referenced this issue Nov 23, 2022
@jeffwashington
feature: on accounts hash calculation, do not try to rehash accounts s…
0f48baf 
…olana-labs#28934
jeffwashington added a commit to jeffwashington/solana that referenced this issue Nov 23, 2022
@jeffwashington
feature: on accounts hash calculation, do not try to rehash accounts s…
ee2e509 
…olana-labs#28934
jeffwashington added a commit to jeffwashington/solana that referenced this issue Nov 23, 2022
@jeffwashington
feature: on accounts hash calculation, do not try to rehash accounts s…
32480c8 
…olana-labs#28934
jeffwashington added a commit to jeffwashington/solana that referenced this issue Nov 23, 2022
@jeffwashington
feature: on accounts hash calculation, do not try to rehash accounts s…
1847cc9 
…olana-labs#28934
jeffwashington added a commit to jeffwashington/solana that referenced this issue Nov 23, 2022
@jeffwashington
add feature solana-labs#28934
54118e3
jeffwashington added a commit to jeffwashington/solana that referenced this issue Nov 23, 2022
@jeffwashington
feature: on accounts hash calculation, do not try to rehash accounts s…
7ff7691 
…olana-labs#28934
@jeffwashington jeffwashington mentioned this issue Nov 23, 2022
Closed
14 tasks
jeffwashington added a commit to jeffwashington/solana that referenced this issue Nov 23, 2022
@jeffwashington
Revert "feature: on accounts hash calculation, do not try to rehash a…
1ada4fa 
…ccounts solana-labs#28934"

This reverts commit 7ff7691.
This was referenced Nov 23, 2022
Merged
Merged
jeffwashington added a commit to jeffwashington/solana that referenced this issue Nov 28, 2022
@jeffwashington
Revert "feature: on accounts hash calculation, do not try to rehash a…
e0ef8f1 
…ccounts solana-labs#28934"

This reverts commit 7ff7691.
willhickey pushed a commit that referenced this issue Nov 28, 2022
@jeffwashington @brooksprumo
feature: on accounts hash calculation, do not try to rehash accounts (#…
af329cf 
…28935)

* add feature #28934

* feature: on accounts hash calculation, do not try to rehash accounts #28934

* Delete syscalls.txt

* retain feature 28541

Co-authored-by: Brooks Prumo <brooks@prumo.org>
jeffwashington added a commit to jeffwashington/solana that referenced this issue Nov 28, 2022
@jeffwashington
Revert "feature: on accounts hash calculation, do not try to rehash a…
f896299 
…ccounts solana-labs#28934"

This reverts commit 7ff7691.
jeffwashington added a commit that referenced this issue Nov 28, 2022
@jeffwashington
add feature #28934 (no-op in master) (#28936)
7999f42
jeffwashington added a commit to jeffwashington/solana that referenced this issue Dec 2, 2022
@jeffwashington
Revert "feature: on accounts hash calculation, do not try to rehash a…
084c318 
…ccounts solana-labs#28934"

This reverts commit 7ff7691.
jeffwashington added a commit that referenced this issue Dec 2, 2022
@jeffwashington
revert rehash due to rent_epoch change (#28943)
df75b7b 
Revert "feature: on accounts hash calculation, do not try to rehash accounts #28934"

This reverts commit 7ff7691.
gnapoli23 pushed a commit to gnapoli23/solana that referenced this issue Dec 16, 2022
@jeffwashington @gnapoli23
add feature solana-labs#28934 (no-op in master) (solana-labs#28936)
0b7ff8d
nickfrosty pushed a commit to nickfrosty/solana that referenced this issue Jan 4, 2023
@jeffwashington @nickfrosty
add feature solana-labs#28934 (no-op in master) (solana-labs#28936)
6534bc8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeffwashington