This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Token amounts wasting a bit by using i64 #1526
Assignees
Milestone
Comments
garious
added a commit
to garious/solana
that referenced
this issue
Nov 5, 2018
garious
added a commit
that referenced
this issue
Nov 5, 2018
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this issue
Aug 29, 2021
…olana-labs#1526) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.17.0 to 4.20.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.20.0/packages/parser) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
TESLA-SATI
pushed a commit
to TESLA-SATI/solana
that referenced
this issue
May 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Problem:
When the contract engine was added, the use of an
i64type for tokens instead of au64became pointless. Each program would need to define an associative operation on the type held in its userdata so that it could coalesce from the right in forked banks. And since that operation would probably require deserialization, it's looking especially unlikely that we'd go that route.Proposed solution:
Change i64 to u64 and delete checks for negative tokens ...and stop worrying about missing checks for negative tokens.
The text was updated successfully, but these errors were encountered: