fix: include exception identifier in catch blocks (#25147)

solana-labs · May 12, 2022 · a38ce12 · a38ce12
1 parent 86ffd98
commit a38ce12
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/web3.js/src/connection.ts b/web3.js/src/connection.ts
@@ -4847,7 +4847,7 @@ export class Connection {
             try {
               this.removeSignatureListener(clientSubscriptionId);
               // eslint-disable-next-line no-empty
-            } catch {
+            } catch (_err) {
               // Already removed.
             }
           }
@@ -4895,7 +4895,7 @@ export class Connection {
           try {
             this.removeSignatureListener(clientSubscriptionId);
             // eslint-disable-next-line no-empty
-          } catch {
+          } catch (_err) {
             // Already removed.
           }
         },

diff --git a/web3.js/test/connection.test.ts b/web3.js/test/connection.test.ts
@@ -3614,7 +3614,7 @@ describe('Connection', function () {
             await connection._rpcWebSocket.notify('ping');
             break;
             // eslint-disable-next-line no-empty
-          } catch {}
+          } catch (_err) {}
           await sleep(100);
         }
       });