This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 924
feat: Agave v2 RPC: replace getConfirmedBlock
with getBlock
#3417
Merged
buffalojoec
merged 1 commit into
maintenance/v1.x
from
10-23-feat_agave_v2_rpc_replace_getconfirmedblock_with_getblock_
Dec 16, 2024
Merged
feat: Agave v2 RPC: replace getConfirmedBlock
with getBlock
#3417
buffalojoec
merged 1 commit into
maintenance/v1.x
from
10-23-feat_agave_v2_rpc_replace_getconfirmedblock_with_getblock_
Dec 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 23, 2024
buffalojoec
force-pushed
the
10-23-feat_agave_v2_rpc_replace_getconfirmedblock_with_getblock_
branch
from
October 29, 2024 07:05
2fe2282
to
6acd1dc
Compare
lorisleiva
reviewed
Oct 29, 2024
buffalojoec
force-pushed
the
10-23-feat_agave_v2_rpc_replace_getconfirmedblock_with_getblock_
branch
from
October 29, 2024 09:54
6acd1dc
to
22a65a5
Compare
lorisleiva
approved these changes
Oct 29, 2024
mcintyre94
approved these changes
Oct 29, 2024
buffalojoec
force-pushed
the
10-23-feat_agave_v2_rpc_replace_getconfirmedblock_with_getblock_
branch
from
November 18, 2024 11:49
22a65a5
to
77b6e59
Compare
buffalojoec
force-pushed
the
10-23-feat_agave_v2_rpc_replace_getconfirmedblock_with_getblock_
branch
from
November 27, 2024 11:56
77b6e59
to
c35251a
Compare
buffalojoec
force-pushed
the
10-23-feat_agave_v2_rpc_replace_getconfirmedblock_with_getblock_
branch
from
December 6, 2024 07:26
c35251a
to
6607d91
Compare
buffalojoec
force-pushed
the
10-23-feat_agave_v2_rpc_replace_getconfirmedblock_with_getblock_
branch
from
December 6, 2024 07:29
6607d91
to
e730045
Compare
steveluscher
approved these changes
Dec 15, 2024
buffalojoec
deleted the
10-23-feat_agave_v2_rpc_replace_getconfirmedblock_with_getblock_
branch
December 16, 2024 04:15
🎉 This PR is included in version 1.96.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
With the upcoming upgrade from 1.18 to 2.0 on Solana mainnet-beta, deprecated RPC methods have been removed, therefore they will no longer be available through Web3.js client requests.
The Agave 2.0 Migration Guide lists semi-equivalent RPC method counterparts for each of the removed methods.
Summary of Changes
Replace
getConfirmedBlock
withgetBlock
. This method was already requiring a confirmation level ofconfirmed
orfinalized
, so the behavior should be unchanged.